Wait for services to be registered before performing further setup that requires services#2275
Merged
juliusknorr merged 4 commits intomasterfrom Sep 10, 2020
Merged
Wait for services to be registered before performing further setup that requires services#2275juliusknorr merged 4 commits intomasterfrom
juliusknorr merged 4 commits intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
ChristophWurst
approved these changes
Sep 8, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
lib/AppInfo/Application20.php
Outdated
|
|
||
| public function registerCommentsEntity(): void { | ||
| $this->server->getEventDispatcher()->addListener(CommentsEntityEvent::EVENT_ENTITY, function (CommentsEntityEvent $event) { | ||
| public function registerCommentsEntity(SymfonyAdapter $symfonyAdapter): void { |
Member
There was a problem hiding this comment.
\OCP\Comments\CommentsEntityEvent is a "new" event based on \OCP\EventDispatcher\Event. Aren't you able to use our dispatcher abstraction?
Signed-off-by: Julius Härtl <jus@bitgrid.net>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise databaseType and database4ByteSupport are not being resolved properly